Skip to content

Miri subtree update #141116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 17, 2025
Merged

Miri subtree update #141116

merged 21 commits into from
May 17, 2025

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented May 17, 2025

r? @ghost

RalfJung and others added 20 commits May 7, 2025 10:45
@RalfJung
test suite: use CARGO_TARGET_TMPDIR for temporary build artifacts
0d5df70
@RalfJung
Merge pull request rust-lang#4313 from RalfJung/CARGO_TARGET_TMPDIR
67f6726 
test suite: use CARGO_TARGET_TMPDIR for temporary build artifacts
@RalfJung
remove stray stderr file
c70dc45
@RalfJung
remove commented-out test leftover
8930c41
@RalfJung
Merge pull request rust-lang#4315 from RalfJung/test-cleanup
514d546 
remove stray stderr file
@est31
Update miri, cargo-miri and miri-cript to edition 2024
070fee2 
Also update the format edition to 2024
@RalfJung
Merge pull request rust-lang#4311 from est31/edition_2024
d0e63b2 
Update to edition 2024
@est31
Remove let_chains feature as it is stable
a1234d3
@RalfJung
Merge pull request rust-lang#4316 from est31/no_let_chains
c4cffce 
Remove let_chains feature as it is stable
Preparing for merge from rustc
6e5d647
Merge from rustc
a4f765d
@oli-obk
Merge pull request rust-lang#4318 from rust-lang/rustup-2025-05-10
cbd4db0 
Automatic Rustup
Preparing for merge from rustc
30eca8b
Merge from rustc
7479482
@RalfJung
Merge pull request rust-lang#4319 from rust-lang/rustup-2025-05-12
8bfc88f 
Automatic Rustup
@RalfJung
Preparing for merge from rustc
3a9ee90
@RalfJung
Merge from rustc
8f2da9b
@RalfJung
fix clippy lints
b99daba
@RalfJung
fix for doctest-xcompile stabilization
ace4c6e
@RalfJung
Merge pull request rust-lang#4324 from RalfJung/rustup
0a28db2 
Rustup
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

RalfJung commented May 17, 2025

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 0a28db2 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

RalfJung commented May 17, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 17, 2025
@RalfJung
Copy link
Member Author

RalfJung commented May 17, 2025

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit bd9f1fd has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 17, 2025
@bors
Copy link
Collaborator

bors commented May 17, 2025

⌛ Testing commit bd9f1fd with merge 2c12b4a...

@bors
Copy link
Collaborator

bors commented May 17, 2025

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 2c12b4a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2025
@bors bors merged commit 2c12b4a into rust-lang:master May 17, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a43b8d1 (parent) -> 2c12b4a (this PR)

Test differences

Show 33148 test diffs

Stage 1

  • array::array_try_from_fn: pass -> [missing] (J0)
  • collections::btree::map::tests::test_insert_into_full_height_1: pass -> [missing] (J0)
  • collections::btree::set::tests::test_extend_ref: pass -> [missing] (J0)
  • collections::linked_list::tests::test_drop_panic: pass -> [missing] (J0)
  • f128::test_real_consts: pass -> [missing] (J0)
  • io::buffered::tests::line_buffer_write0_error: pass -> [missing] (J0)
  • io::cursor::tests::test_mem_reader: pass -> [missing] (J0)
  • io::tests::cursor_read_exact_eof: pass -> [missing] (J0)
  • iter::range::test_range_min: pass -> [missing] (J0)
  • mem::align_of_basic: pass -> [missing] (J0)
  • num::i16::test_unbounded_shl: pass -> [missing] (J0)
  • num::i64::test_num: pass -> [missing] (J0)
  • num::i8::test_abs: pass -> [missing] (J0)
  • num::test_try_i16u64: pass -> [missing] (J0)
  • slice::split_off_mut_in_bounds_range_to_inclusive: pass -> [missing] (J0)
  • slice::test_iterator_last: pass -> [missing] (J0)
  • slice::test_slice_fill_with_uninit: pass -> [missing] (J0)
  • sort::tests::unstable::correct_i32_random_d2: pass -> [missing] (J0)
  • sys_common::wtf8::tests::code_point_to_char: pass -> [missing] (J0)
  • sys_common::wtf8::tests::wtf8buf_truncate_fail_code_point_boundary: pass -> [missing] (J0)
  • system_time_math: pass -> [missing] (J0)
  • test_pop: pass -> [missing] (J0)
  • test_pow: pass -> [missing] (J0)
  • thread::tests::test_thread_id_not_equal: pass -> [missing] (J0)
  • time::debug_formatting_millis: pass -> [missing] (J0)
  • vec::test_slice_out_of_bounds_1: pass -> [missing] (J0)
  • bit_set::tests::bitset_iter_works: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_accessible_multiple_paths_13: pass -> [missing] (J1)
  • errors::verify_interface_multiple_output_types_to_stdout_16: pass -> [missing] (J1)
  • errors::verify_mir_transform_unknown_pass_name_5: pass -> [missing] (J1)
  • errors::verify_parse_inappropriate_default_148: pass -> [missing] (J1)
  • errors::verify_parse_unexpected_token_after_struct_name_found_reserved_identifier_89: pass -> [missing] (J1)
  • errors::verify_passes_rustc_force_inline_coro_86: pass -> [missing] (J1)
  • errors::verify_resolve_cannot_be_reexported_private_32: pass -> [missing] (J1)
  • errors::verify_resolve_macro_use_name_already_in_use_38: pass -> [missing] (J1)
  • errors::verify_trait_selection_but_calling_introduces_21: pass -> [missing] (J1)
  • html::markdown::tests::test_plain_text_summary: pass -> [missing] (J1)
  • leb128::tests::test_isize_leb128: pass -> [missing] (J1)
  • lints::verify_lint_metavariable_wrong_operator_120: pass -> [missing] (J1)
  • obligation_forest::tests::orphan: pass -> [missing] (J1)
  • spec::tests::thumbv8m_main_nuttx_eabi: pass -> [missing] (J1)
  • spec::tests::x86_64_wrs_vxworks: pass -> [missing] (J1)
  • tests::invalid02: pass -> [missing] (J1)
  • array::map_8byte_8byte_256: pass -> [missing] (J2)
  • ascii::long::is_ascii_hexdigit: pass -> [missing] (J2)
  • btree::set::difference_staggered_100_vs_100: pass -> [missing] (J2)
  • char::methods::bench_to_ascii_uppercase: pass -> [missing] (J2)
  • sort::tests::stable::panic_observable_is_less_descending: pass -> [missing] (J2)
  • str::char_count::emoji_huge::case01_filter_count_cont_bytes: pass -> [missing] (J2)
  • str::contains_bang_str::short_mixed: pass -> [missing] (J2)
  • tests::exclude_should_panic_option: pass -> [missing] (J2)
  • vec::bench_chain_extend_ref: pass -> [missing] (J2)
  • vec::bench_extend_0000_0010: pass -> [missing] (J2)
  • collections::btree::node::tests::test_sizes: ignore -> [missing] (J3)
  • sort::tests::unstable::correct_u64_saw_mixed: ignore -> [missing] (J3)

Stage 2

  • array::array_rsplit_array_ref_out_of_bounds: [missing] -> pass (J0)
  • ascii::test_is_ascii_alphanumeric: [missing] -> pass (J0)
  • collections::btree::map::tests::test_bad_zst: [missing] -> pass (J0)
  • collections::btree::map::tests::test_extract_if::underfull_keeping_all: [missing] -> pass (J0)
  • ffi::os_str::tests::into_boxed: [missing] -> pass (J0)
  • ffi::os_str::tests::test_os_str_len: [missing] -> pass (J0)
  • fmt::builders::debug_tuple::test_empty: [missing] -> pass (J0)
  • fmt::test_once: [missing] -> pass (J0)
  • mpmc::oneshot_single_thread_try_recv_closed: [missing] -> pass (J0)
  • num::i16::test_rem_euclid: [missing] -> pass (J0)
  • num::i32::test_div_floor: [missing] -> pass (J0)
  • num::int_log::ilog10_u128: [missing] -> pass (J0)
  • raw_vec::tests::zst: [missing] -> pass (J0)
  • rwlock::test_rw_arc_no_poison_mapped_r_w: [missing] -> pass (J0)
  • slice::memchr::matches_nul_reversed: [missing] -> pass (J0)
  • slice::test_rchunks_exact_nth: [missing] -> pass (J0)
  • slice::test_rchunks_iterator_0: [missing] -> pass (J0)
  • slice::test_rchunks_mut_zip_aliasing: [missing] -> pass (J0)
  • str::test_into_string: [missing] -> pass (J0)
  • str::test_pattern_deref_forward: [missing] -> pass (J0)
  • test_boxed_hasher: [missing] -> pass (J0)
  • test_is_power_of_two_u32: [missing] -> pass (J0)
  • time::debug_formatting_precision_high: [missing] -> pass (J0)
  • vec::test_extend: [missing] -> pass (J0)
  • errors::verify_codegen_ssa_dlltool_fail_import_library_131: [missing] -> pass (J1)
  • errors::verify_lint_builtin_ellipsis_inclusive_range_patterns_1: [missing] -> pass (J1)
  • errors::verify_passes_doc_alias_not_string_literal_27: [missing] -> pass (J1)
  • lints::verify_lint_inner_macro_attribute_unstable_125: [missing] -> pass (J1)
  • server_impl::rust_analyzer_span::tests::test_ra_server_to_string: [missing] -> pass (J1)
  • session_diagnostics::verify_borrowck_cannot_move_when_borrowed_5: [missing] -> pass (J1)
  • spec::tests::csky_unknown_linux_gnuabiv2hf: [missing] -> pass (J1)
  • ascii::long::case02_lookup_table: [missing] -> pass (J2)
  • btree::set::intersection_random_10k_vs_10k: [missing] -> pass (J2)
  • btree::set::intersection_staggered_100_vs_100: [missing] -> pass (J2)
  • num::int_log::u128_log10_random_small: [missing] -> pass (J2)
  • num::int_log::u16_log10_random: [missing] -> pass (J2)
  • num::int_sqrt::u32_sqrt_uniform: [missing] -> pass (J2)
  • process::tests::test_process_output_error: [missing] -> pass (J2)
  • slice::rotate_medium_by727_bytes: [missing] -> pass (J2)
  • sort::tests::stable::panic_observable_is_less_descending: [missing] -> pass (J2)
  • sort::tests::unstable::correct_u128_random_s95: [missing] -> pass (J2)
  • str::char_count::emoji_small::case02_iter_increment: [missing] -> pass (J2)
  • sort::tests::stable::correct_i32_random_d8: [missing] -> ignore (J3)
  • sort::tests::unstable::deterministic_i32_descending: [missing] -> ignore (J3)
  • sort::tests::unstable::self_cmp_string_descending: [missing] -> ignore (J3)

(and 16502 additional test diffs)

Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2c12b4a690c8201a3c79f404eec38614684c412c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 3966.9s -> 1016.9s (-74.4%)
  2. test-various: 4104.9s -> 2271.3s (-44.7%)
  3. dist-aarch64-linux: 5375.6s -> 7614.3s (41.6%)
  4. x86_64-apple-1: 6195.9s -> 8413.3s (35.8%)
  5. x86_64-gnu-aux: 6134.8s -> 4401.4s (-28.3%)
  6. aarch64-apple: 3886.3s -> 3020.7s (-22.3%)
  7. dist-apple-various: 6601.2s -> 5272.7s (-20.1%)
  8. dist-x86_64-apple: 8725.3s -> 7517.3s (-13.8%)
  9. dist-aarch64-apple: 5476.2s -> 4862.2s (-11.2%)
  10. x86_64-mingw-1: 9051.3s -> 8560.5s (-5.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented May 17, 2025

Finished benchmarking commit (2c12b4a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.5% [-0.6%, -0.4%] 2
All ❌✅ (primary) - - 0

Cycles

Results (secondary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.7% [0.5%, 0.8%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.8% [-4.1%, -0.5%] 8
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.898s -> 775.648s (0.10%)
Artifact size: 365.43 MiB -> 365.44 MiB (0.00%)

@RalfJung RalfJung deleted the miri-sync branch May 18, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

7 participants

@RalfJung @rustbot @bors @rust-log-analyzer @rust-timer @est31 @oli-obk